Repository navigation
Fix compare crash when plugins add extra metrics - #4914
Merged
Merged
Conversation
Custom metrics that a plugin or script added to the browsertime extras made the compare run fail with "currentMetric.getValues is not a function". The extras ended up as their own top-level groups instead of one extras group, so compare tried to read metrics from the wrong level. The Graphite export already expected an extras group. Objects in the extras (the axe result is stored there) are skipped, because only numbers can be compared. Fixes #4292 Assisted-by: Claude Opus 5.5 noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom metrics that a plugin or script added to the browsertime extras made the compare run fail with "currentMetric.getValues is not a function". The extras ended up as their own top-level groups instead of one extras group, so compare tried to read metrics from the wrong level. The Graphite export already expected an extras group.
Objects in the extras (the axe result is stored there) are skipped, because only numbers can be compared.
Fixes #4292
Assisted-by: Claude Opus 5.5 noreply@anthropic.com