Repository navigation
Keep every repeated --scriptInput.visualElements - #4919
Merged
Merged
Conversation
Repeating --scriptInput.visualElements to measure several elements only kept the last one. yargs mixed the option up with the boolean --visualElements, which has the same last name segment, and treated the repeats as a boolean flag set twice. Browsertime already accepts a list here, and its help tells users to repeat the option. Fixes #4458 Assisted-by: Claude Opus 5.5 noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeating --scriptInput.visualElements to measure several elements only kept the last one. yargs mixed the option up with the boolean --visualElements, which has the same last name segment, and treated the repeats as a boolean flag set twice. Browsertime already accepts a list here, and its help tells users to repeat the option.
Fixes #4458
Assisted-by: Claude Opus 5.5 noreply@anthropic.com