Repository navigation
fix(infra): allow traceql metrics queries beyond 3h - #3810
Conversation
Tempo caps metrics queries at query_frontend.metrics.max_duration, which defaults to 3h. The chart left query_frontend empty, so any TraceQL metrics query over a longer range returned 400 even though blocks are retained for 90 days. Trace search was unaffected (its own limit is 168h). Set the metrics limit to 168h to match trace search. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughTempo Helm values now set the query frontend metrics maximum duration to 168 hours. ChangesTempo metrics query duration
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The configuration is positioned to raise the metrics-query limit to seven days. No identified issue prevents merging after normal checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to Seven-day metrics queries can increase load on trace monitoring and its storage. The change does not add credentials, privileges, or an external access path, and it is reversible through configuration. Effective workload limits and runtime behavior remain unverified. Retained concerns
Security review detailsSecurity Blast Radius
Security Findings and Attack Paths
Trust Boundaries and Controls
Hardening Proposals
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Grafana에서 3시간이 넘는 구간을 잡으면 트레이스로 만든 그래프가 비어 버리는 문제를 고칩니다.
트레이스 자체는 90일치가 저장돼 있고 검색도 잘 됩니다. 막히는 건 트레이스를 모아 그린 그래프(요청량·응답시간 추이)뿐인데, Tempo가 이 그래프만 "한 번에 3시간어치까지"로 제한하고 있었습니다. 우리가 이 값을 정해준 적이 없어서 Tempo 기본값이 그대로 쓰이던 상태입니다.
상한을 7일로 올립니다. 트레이스 검색 쪽에 이미 적용돼 있던 값과 같은 값입니다.
Additional context
보존 기간(90일)은 데이터를 얼마나 오래 들고 있을지를 정하는 값이고, 이번에 고친 상한은 한 번에 몇 시간어치를 그려줄지를 정하는 값입니다.
Before submitting the PR, please make sure you do the following
Closes TAS-3083
🤖 Generated with Claude Code
Summary by CodeRabbit