Repository navigation
chore(deps): bump Go to 1.27.2 and refresh dependencies - #660
Merged
Merged
Conversation
govulncheck fails the Build workflow on every dependency PR (see #659) because golang.org/x/net v0.59.0 carries five HTTP/2 advisories that are reachable from this code: GO-2026-6603, -6610, -6611, -6612 and -6617, all fixed in v0.60.0. - go directive 1.27.1 -> 1.27.2 - direct dependencies via `make go-mod-update` (aws-sdk-go-v2, golang.org/x/sync, google.golang.org/api) - golang.org/x/net v0.59.0 -> v0.61.0, raised explicitly because `make go-mod-update` only upgrades direct dependencies - cloud.google.com/go/auth pinned to the tagged v0.24.1 instead of the untagged pre-release commit google.golang.org/api v0.301.0 asks for No code changes; golden hashes are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Lint job pinned golangci-lint v2.13.1, which cannot read the export data Go 1.27.2 writes and fails typecheck on every package: export data version 5 is greater than maximum supported version 4 v2.14.0 reads it, and reports 0 issues against the committed config. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A pinned linter goes stale against the toolchain in go.mod: v2.13.1 could not read the export data Go 1.27.2 writes, so the Lint job failed typecheck on every package until the pin was moved by hand. Following the latest release removes that maintenance step. The trade-off is that a new linter release can fail the job with no change in the repository. The action itself stays SHA-pinned. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
govulncheckfails the Test and Build job on every dependency PR — see #659 — becausegolang.org/x/netv0.59.0 carries five HTTP/2 advisories thatgovulncheckreports as reachable from this code (for example throughpkg/aws/scim.go). Go 1.27.2 is also out, so this moves the toolchain and refreshes everything in one pass.This PR supersedes #659: it contains the same six bumps at the same or newer versions, plus the fix that #659 is missing.
What changed
go.mod,go.sum, one workflow line and docs. No Go source changed.godirectivegithub.com/aws/aws-sdk-go-v2…/config…/credentials…/service/s3…/service/secretsmanagergolang.org/x/syncgoogle.golang.org/apigolang.org/x/net(indirect)golang.org/x/crypto(indirect)cloud.google.com/go/auth(indirect)golangci-lintinbuild.ymllatestOther indirect modules moved with them; see the
go.moddiff.Three things that go beyond
make go-mod-updateReviewers should look at these, because the make target did not produce them on its own:
golang.org/x/netwas raised by hand.make go-mod-updaterunsgo get -uon direct dependencies only, and it leftx/netat the vulnerable v0.59.0.go get golang.org/x/net@latesttook it to v0.61.0 (andx/cryptoto v0.58.0 with it). This clears GO-2026-6603, GO-2026-6610, GO-2026-6611, GO-2026-6612 and GO-2026-6617, all fixed in v0.60.0.cloud.google.com/go/authis pinned to the tagged v0.24.1.google.golang.org/apiv0.301.0 requires the untagged pre-release commitv0.24.1-0.20261001053825-dbc26066f70a. The tagged v0.24.1 is the next release after that commit, so the Google authentication path does not run on an unreleased commit. Drop this pin if you would rather stay on exactly what upstream declares.golangci-lintis no longer pinned in the Lint job. The first push of this branch failed Lint: the pinned v2.13.1 cannot read the export data Go 1.27.2 writes (export data version 5 is greater than maximum supported version 4) and failed typecheck on every package. The job now usesversion: latest, so the linter cannot go stale against the toolchain again. The trade-off is that a new linter release can fail CI with no change in the repository. The action itself stays SHA-pinned.Verification
Local (Go 1.27.2, darwin/arm64, golangci-lint v2.14.0):
go mod verify— all modules verifiedgovulncheck ./...— 0 vulnerabilities called (before thex/netbump: 5). One module-level notice remains, GO-2026-5932 for the unmaintainedx/crypto/openpgppackage, which this code does not import and which has no fixed version.go fix ./...,make go-fmt,make go-betteralign,make go-generate— no diffgolangci-lint run ./...— 0 issuesmake build— both binaries buildmake test(-race) — all packages passinternal/modelgolden hash tests — pass unchanged, so state files and hashes are unaffectedCI on this branch: Lint, Test and Build (including
govulncheck), fuzz targets and CodeQL all pass.Release
Folded into the existing Unreleased entry in
docs/Whats-New.md, which targetsv0.46.0(minor).docs/Development.mdnow states the correctgodirective and linter requirement.🤖 Generated with Claude Code