Repository navigation
fix: the lease race eval waits for the first write instead of 10 ms - #107
Merged
Merged
Conversation
…e has landed It wrote after a fixed 10 ms. On a loaded machine the first instance's write landed after the rival's, so it won and the eval failed. It now waits for that write and gives the read-back 500 ms. The read-back itself gets a mutant. Co-Authored-By: Truong Le Vinh Phuc <truonglevinhphuc2006@gmail.com>
|
Deployment failed for project scriptorium with the following error: Learn More: https://vercel.com/sloweyyy?upgradeToPro=build-rate-limit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
evals/lease.test.ts› "a concurrent writer that won the race is caught by the read-back" failed once in a full gate run while a mutation run loaded the machine.Cause: the eval wrote the rival's lease after a fixed 10 ms. If the first instance's own write landed later than that, it overwrote the rival's lease, read itself back, and won.
Fix:
Gate: typecheck clean, 769 evals passed. The lease suite passed 3/3 on its own.
Co-Authored-By: Truong Le Vinh Phuc truonglevinhphuc2006@gmail.com