Repository navigation
fix: Scribe works only from comments everyone on the ticket can see - #109
Merged
Merged
Conversation
Scribe's drafts, their attachments, the published doc and lessons are public. Feedback or a command in a comment restricted to a role or group, or in a Jira Service Management internal note, was worked from all the same, and repeated in public. - A restricted comment addressed to Scribe is answered once, at its own restriction, and not acted on. Plain prose in one is passed over in silence. - A comment whose restriction can't be read is neither acted on nor answered. - After a lost ledger, a draft asked for in a restricted comment doesn't make the ticket one Scribe drafts. - `commentRestriction` moves to @scriptorium/jira, so Scribe and the webhook ingress read a restriction the same way. This closes the known gap in docs/security-model.md. Co-Authored-By: Truong Le Vinh Phuc <truonglevinhphuc2006@gmail.com>
|
Deployment failed for project scriptorium with the following error: Learn More: https://vercel.com/sloweyyy?upgradeToPro=build-rate-limit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scribe's drafts, their
.mdattachments, the published doc and lessons are all public. Feedback or a command in a comment restricted to a role or group, or in a Jira Service Management internal note, was worked from anyway, and what it said ended up in public.docs/security-model.mdlisted this as a known gap.Now
draftasked for in a restricted comment doesn't make an unlabelled ticket one Scribe drafts.commentRestrictionmoves from the webhook ingress to@scriptorium/jira, so Scribe and the Teammate read a restriction the same way.saytakes an optional restriction.Evals (
jira-board):approvepublishes nothing and is answered at the same visibility.draftdoesn't engage the ticket.7 new mutants (395), all red.
Gate: typecheck clean, 776 evals passed.
Co-Authored-By: Truong Le Vinh Phuc truonglevinhphuc2006@gmail.com