Skip to content

fix: Scribe works only from comments everyone on the ticket can see - #109

Merged
sloweyyy merged 1 commit into
mainfrom
fix/scribe-works-only-from-public-comments
Oct 8, 2026
Merged

sloweyyy merged 1 commit into
mainfrom
fix/scribe-works-only-from-public-comments

Conversation

@sloweyyy

@sloweyyy sloweyyy commented Oct 8, 2026

Copy link
Copy Markdown
Owner

Scribe's drafts, their .md attachments, the published doc and lessons are all public. Feedback or a command in a comment restricted to a role or group, or in a Jira Service Management internal note, was worked from anyway, and what it said ended up in public. docs/security-model.md listed this as a known gap.

Now

  • A restricted comment addressed to Scribe (a command or a mention) is answered once, at its own restriction: "I only work from comments everyone on this ticket can see…". It is not acted on.
  • Plain prose in a restricted comment is passed over in silence. It's usually people talking among themselves.
  • A comment whose restriction can't be read is neither acted on nor answered, as the Teammate already does.
  • After a lost ledger, a draft asked for in a restricted comment doesn't make an unlabelled ticket one Scribe drafts.
  • commentRestriction moves from the webhook ingress to @scriptorium/jira, so Scribe and the Teammate read a restriction the same way. say takes an optional restriction.

Evals (jira-board):

  • A restricted approve publishes nothing and is answered at the same visibility.
  • Feedback in an internal note triggers no model call and no reply.
  • An unreadable restriction is ignored.
  • After a lost ledger, a restricted draft doesn't engage the ticket.

7 new mutants (395), all red.

Gate: typecheck clean, 776 evals passed.

Co-Authored-By: Truong Le Vinh Phuc truonglevinhphuc2006@gmail.com

Scribe's drafts, their attachments, the published doc and lessons are public. Feedback or
a command in a comment restricted to a role or group, or in a Jira Service Management
internal note, was worked from all the same, and repeated in public.

- A restricted comment addressed to Scribe is answered once, at its own restriction, and
  not acted on. Plain prose in one is passed over in silence.
- A comment whose restriction can't be read is neither acted on nor answered.
- After a lost ledger, a draft asked for in a restricted comment doesn't make the ticket
  one Scribe drafts.
- `commentRestriction` moves to @scriptorium/jira, so Scribe and the webhook ingress read
  a restriction the same way.

This closes the known gap in docs/security-model.md.

Co-Authored-By: Truong Le Vinh Phuc <truonglevinhphuc2006@gmail.com>
@vercel

vercel Bot commented Oct 8, 2026

Copy link
Copy Markdown

Deployment failed for project scriptorium with the following error:

Resource is limited - try again in 24 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/sloweyyy?upgradeToPro=build-rate-limit

@sloweyyy
sloweyyy merged commit f40954d into main Oct 8, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant