Repository navigation
fix: an approval that thanks someone asks them nothing, and "please" with a group asks it - #110
Merged
Merged
Conversation
…said with a group asks it From review R7 of #103: - "Approve please, thanks everyone" and "Approve pls\nThanks team!" published. With a "please" anywhere, a group is asked, thanked or not. - A line mentioning someone only had to start with thanks: "Thanks, [~legal] please 🙏" and "Thanks [~legal], please ship it" published. A mention line is now a plain cc ("cc [~legal]", "fyi") or thanks and nothing else. - Friendly forms refused before now approve: "Approved, thanks [~dev]!", "Approved, ty team", "lovely work team", "congratulations team". Co-Authored-By: Truong Le Vinh Phuc <truonglevinhphuc2006@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes R7-3, R7-4 and R7-7 from the review of #102–#104. A plain-comment
approvepublishes on the spot, so a comment that asks someone else to approve must not be read as an approval.No longer publishes (
packages/jira/src/commands.ts)cc, mentions,and,fyi; orNow publishes (friendly forms refused before)
Evals: the cases above in
evals/jira.test.ts. 5 new mutants, 5 stale finds repointed (400). All grammar mutants are red.Gate: typecheck clean, 776 evals passed. A full
pnpm mutateon main at #104 killed all 370.Co-Authored-By: Truong Le Vinh Phuc truonglevinhphuc2006@gmail.com