Repository navigation
fix: Scribe makes a board move it couldn't check on a later tick, from where it meant it - #112
Merged
Merged
Conversation
…m where it meant it From review R7 of #104: when the status read before a move failed, the move was skipped and never retried. A drag to Approved by someone who can't approve was refused, but stayed in Approved, and the end of the tick took that as the baseline. The board said an approval had counted. A move whose status read, or whose transition, fails is now kept with the column it was meant from. A later tick makes it while the ticket is still there, and drops it once someone has moved the ticket on. It is still never moved blind. Co-Authored-By: Truong Le Vinh Phuc <truonglevinhphuc2006@gmail.com>
|
Deployment failed for project scriptorium with the following error: Learn More: https://vercel.com/sloweyyy?upgradeToPro=build-rate-limit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes R7-6 from the review of #102–#104.
The bug. Since #104,
moveTodoesn't move a ticket whose live status it couldn't read, so it never overrides a column a person just chose. But the skipped move was never retried:The fix
pendingMove: { to, from }.fromis the column the agent meant to move it from.from, and dropped once someone has moved it elsewhere.Evals (
jira-board, with new hooks that fail the next issue read or transition):4 new mutants, 2 repointed (408). All context.ts mutants are red.
Gate: typecheck clean, 779 evals passed.
Co-Authored-By: Truong Le Vinh Phuc truonglevinhphuc2006@gmail.com