[rudycelekli]

Bug

POST /api/v1/servers/{id}/config-to-secret refuses to convert a value that is already a reference, but the check is strings.HasPrefix(value, "${keyring:") || strings.HasPrefix(value, "${env:"). Two kinds of values get past it:

• a ${file:/path} reference (the provider added in feat(secret): ${file:/absolute/path} references (Spec 111 FR-030) #1717);
• a composite value with an embedded reference, such as the documented "Authorization": "Bearer ${keyring:github-token}" (docs/features/keyring-integration.md).

For these values the handler stores the literal text in the keyring and rewrites the field to ${keyring:<secret_name>}. Secret expansion runs once, so on the next connect the upstream gets the unresolved text, for example Bearer ${keyring:github-token} or ${file:/run/secrets/github-token}, as its credential.

The API masks both values on the read path because IsConfigReference only passes through an exact ${keyring:..} or ${env:..} value. The UI therefore shows them as plain secrets and offers Convert-to-secret.

Trigger

"headers": {"Authorization": "Bearer ${keyring:github-token}"}

POST /api/v1/servers/<name>/config-to-secret with {"scope":"header","key":"Authorization","secret_name":"gh2"} succeeds. After that, the header sent upstream is the literal Bearer ${keyring:github-token}.

Fix

Use secret.IsSecretRef(value), which matches any ${type:name} reference anywhere in the value. The handler then returns the existing 400 "already a reference" error for these values.

Test

Two cases added to TestHandleConvertConfigToSecret_ValidationErrors: an env value ${file:/run/secrets/github-token} and a header Bearer ${keyring:github-token}. Both must be rejected with 400 before the resolver is called.

Commands run

• CGO_ENABLED=0 go test -count=1 ./internal/httpapi: ok
• With server.go reverted, both new cases fail (expected: 400, actual: 500). The handler gets past validation and reaches the resolver, which the mock leaves nil.
• go vet ./internal/httpapi, gofmt -l internal/httpapi/: clean

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[Dumbris]

Verified the bug on main and the fix; thank you! The review found one gap, so I pushed a small maintainer commit on top of your branch: with the broader IsSecretRef guard, a mixed value like postgres://app:hunter2@${env:DB_HOST}/app reaches the 400 branch, which echoed the whole value and leaked its literal credential. The error now names only the scope and key.

I will merge once CI is green.

[Dumbris]

Verified: the bug reproduces on main and the PR fixes it. The review found one gap, closed by the maintainer commit on top (regression test included). Race tests and CI lint for the touched packages are clean on this branch merged with main, and the result was cross-reviewed clean.

[Dumbris]

Merged. Thank you, @rudycelekli! Config-to-secret now refuses ${file:} and embedded references like Bearer ${keyring:x}, and the 400 no longer echoes the secret value back. I checked both cases on a live instance before merging.

Contributions like this are what keep MCPProxy moving, and they matter a lot to the project.

One small ask, only if you feel like it: a short public note about your change (a tweet, a LinkedIn post, a line in a community you are part of) helps more people discover MCPProxy. No pressure at all, and I would be glad to repost it.