Repository navigation
Retry the model manifest fetch in stage-model.sh - #285
Merged
Merged
Conversation
On Nov 5 the release build failed on every platform at "Stage bundled resources": the manifest request to api.smartloop.ai hung for the full 60s and the script gave up after one attempt, with no reason logged. - Retry up to 5 more times, 10s apart, on timeouts, refused connections and 408/429/5xx; each attempt gets 30s (about 4 minutes worst case) - -S so the log shows why the last attempt failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The 1.0.69 release build (run 42085166947) failed on every platform at Stage bundled resources. The request for the model download manifest (
/v1/models/slp-orchestra-mini/download) hung for the full 60s, and the script gave up after that single attempt. The log only said "Could not reach the download manifest", with no reason.The API side of this is fixed in smartloop-ai/slp-api#161 (stuck DB calls now time out and return 503). This makes the build tolerate a transient failure too.
What
scripts/stage-model.sh:curl --retry 5 --retry-delay 10 --retry-connrefused: retries timeouts, refused connections and 408/429/5xx. That includes a 503 from the API or a 429 from its 5/minute download limit.--max-time 30per attempt (was 60, single try): about 4 minutes worst case.-S: the log now shows why the last attempt failed (timeout vs HTTP status).Testing
bash -n scripts/stage-model.sh