T148: refuse dispatch on Windows, fix parity, merge main - #127
Merged
Merged
Conversation
Update docs/readme
Update docs: plain irm | iex for Windows install
Dispatch renders a POSIX $SHELL -lc launch line, which a Windows Herdr pane cannot run. ctrl+g, the palette, and tsk dispatch now refuse on Windows with unsupported-platform before any worktree is created, and the POSIX shell-quoting test runs on Unix only. The landing tsk add --json sample gains the assignee key the CLI now emits, and the PTY smoke expects the dispatch peek footer order (#thread · project).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
T148: get
dispatch(PR #120) CI green and current withmain.Changes
origin/main(Update docs/readme #119, Update docs: plain irm | iex for Windows install #121) into the branch (merge commit, no rebase).unsupported-platform("dispatch needs herdr on macOS or Linux") at the board (ctrl+g, palette, dispatch again) andtsk dispatchboundaries, before any worktree, workspace, or POSIX$SHELL -lcline is created. Cleanup is unchanged.rendering_shell_quotes_a_prompt_containing_a_single_quote(spawns/bin/sh) is#[cfg(unix)].dispatch_refusals_print_stable_codes_and_persist_nothingis#[cfg(unix)]; new#[cfg(windows)]dispatch_refuses_on_windows_and_persists_nothing;platform_gate_refuses_only_windowsruns on both.[data-cli-add-output]sample gains"assignee":null(realtsk add --jsonoutput). The PTY smoke expected main's peek footer└─ tsk-parity; dispatch's order is#thread · project, so it now expects└─ #release · tsk-parity.board.md,cli.md(+unsupported-platformin both refusal lists),llms.txt, CHANGELOG Unreleased dispatch line.Proof (local, macOS arm64)
cargo fmt --check && cargo clippy --all-targets -- -D warnings && cargo test: green, 1335 passed, 0 failed.cargo clippy --all-targets --target x86_64-pc-windows-gnu -- -D warnings: clean.site:npm ci && npm test(49 pass)&& npm run buildOK.npm run test:parity: 46 passed;python ../scripts/parity-pty-smoke.py: all four widths OK.CI does not run on PRs into
dispatch(ci.yml/parity.ymlpull_request.branches: [main]), so the Windows jobs run on #120 once this merges.