Repository navigation
NO-SNOW: fix daily precommit tests for disabled SQL simplifier and no-pandas - #4501
Merged
Merged
Conversation
…-pandas - test_trace_sql_errors_to_df: without the simplifier the join resolves the schema of left with its own plan sql, so only the failing operation is mapped; the large query breakdown case fails eagerly in with_column, so it needs the simplifier. - test_try_cast_double_invalid_is_none: skip the to_pandas dtype check without pandas.
sfc-gh-yuwang
requested review from
sfc-gh-aling,
sfc-gh-bkogan and
sfc-gh-mayliu
November 12, 2026 04:28
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4501 +/- ##
=======================================
Coverage 95.47% 95.47%
=======================================
Files 179 179
Lines 46927 46922 -5
Branches 8110 8106 -4
=======================================
- Hits 44803 44800 -3
+ Misses 1332 1331 -1
+ Partials 792 791 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sfc-gh-yuwang
added
the
NO-CHANGELOG-UPDATES
sfc-gh-jzeng
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test-only fixes for daily_precommit failures found during 1.57.0 validation (also failing on main):
test_trace_sql_errors_to_df.py, added in SNOW-4412764: Map a SQL compilation error to the operations of the failing part of the query #4486/SNOW-4412768: Map SQL errors against the query that failed, not always the last one #4472):test_sql_error_of_another_query_reports_all_operations[*]: without the simplifier, the join resolvesleft's schema withleft's own plan SQL, soown_onlyapplies and only the failingwith_columnline is mapped ([152]instead of[151, 152, 155]). That is the correct, more precise output; the test now expects it in that mode.test_sql_error_in_query_before_or_after_pre_actions[_large_query_breakdown_partition-*]: without the simplifierwith_columnresolves the schema eagerly, so the error is raised while the DataFrame is built, before any partition runs. Skipped in that mode.test_column.py::test_try_cast_double_invalid_is_none, added in SNOW-4467757: Add TRY_TO_* conversion functions #4496): theto_pandas()dtype check now only runs when pandas is available; thetry_cast/collect()checks still run.Test plan
--disable_sql_simplifier: 3 passed, 1 skipped (was 3 failed). With the simplifier on: passed.Generated with Snowflake CoCo