Repository navigation
connections: app shell with independent panes, sidebar panel, tenant sublines - #273
Closed
jseifeddine wants to merge 1 commit into
Closed
jseifeddine wants to merge 1 commit into
jseifeddine wants to merge 1 commit into
Conversation
jseifeddine
force-pushed
the
ux/connections-app-shell
branch
2 times, most recently
from
October 13, 2026 07:04
358c20b to
d7ad9e9
Compare
…sublines The sticky sidebar was sized from the viewport rather than from where it starts under the header, so at the top of the page its bottom hung off screen and the page had to be scrolled before the list could be scrolled to its end. The page is now an app shell: the header stays, and the sidebar and the entries area are two independent scroll panes that always fit the viewport. Selecting a folder scrolls the entries pane, not the page. The sidebar is a bordered panel: one pinned header band on a surface tone with the Folders label, a compact new-folder button and the filter box, then the list with hairline dividers, 46px rows and one 12px edge for every band. "host (Tenant)" names read as the host over a quieter tenant line in the entries and search tables, and a role-gate reconciliation covers API-key users. Part of sol1#254 connections: scroll only the entries pane on selection, clip the body jumpToEntriesHeader() used scrollIntoView(), which scrolls every scrollable ancestor, and a body with overflow hidden can still be scrolled by script: selecting a folder pushed the brand row and the nav off the top of the page. Scroll the entries pane to its top instead, and make the body overflow: clip, which no script can scroll. The body's border box now spans the full height so the page padding stays inside the viewport. Part of sol1#254 tests: app shell with two independent scroll panes and a clipped body (sol1#254)
jseifeddine
force-pushed
the
ux/connections-app-shell
branch
from
October 16, 2026 11:29
d7ad9e9 to
ba4d7fc
Compare
This was referenced Oct 16, 2026
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies to
maindirectly: #271 and #272, which this used to build on, are merged (1421665..9d7d675). One commit.Closes #254 (part 3/3).
The header stays; the sidebar and the entries area are two independent scroll panes that always fit the viewport; selecting a folder scrolls the entries pane, not the page (
overflow: clipon the body so no script can scroll it). The sidebar becomes a bordered panel with a pinned header band; "host (Tenant)" names read as the host over a quieter tenant line.Testing
connections-app-shell.spec.mjs.