Repository navigation
sessions: move the ad-hoc session form into a modal - #275
Closed
jseifeddine wants to merge 1 commit into
Closed
jseifeddine wants to merge 1 commit into
jseifeddine wants to merge 1 commit into
Conversation
jseifeddine
force-pushed
the
ux/sessions-adhoc-modal
branch
2 times, most recently
from
October 13, 2026 07:04
ed58c1a to
872cc61
Compare
jseifeddine
marked this pull request as ready for review
October 13, 2026 07:13
The ad-hoc session form sat in a collapsible framed box above the session list. It now opens as a modal from a button on the right of the Sessions heading, dropping the page's framed form box inside the dialog, with the primary button first and Cancel at the same height as Connect, matching the other modals. Section headings centre their heading and action button on one line. Part of sol1#254 tests: the ad-hoc session form opens as a modal
jseifeddine
force-pushed
the
ux/sessions-adhoc-modal
branch
from
October 16, 2026 11:29
872cc61 to
7048ca6
Compare
Member
|
Merged into main as e1746b4 thanks Jad. Looks good on our canary. |
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on current
mainon its own: one commit, nothing from any other open PR.Fixes #262.
The form opens as a modal from a button on the right of the Sessions heading, drops the page's framed form box inside the dialog, primary button first and Cancel the same height as Connect.
Testing
sessions-adhoc-modal.spec.mjs(opens from the heading button, Cancel closes, buttons share a height, a viewer gets no button).