SEP_Fit-Spectra: Handle spectrum units and improve intensity_zero_guess handling - #166
Conversation
…s to the function plot_spectrum().
…arameter (default: E_0=0.1)
…is broke the system and fits are now incorrect
…() works with E_0.
|
Related to #161 |
|
|
||
|
|
||
| def MAKE_THE_FIT(spec_e, spec_flux, e_err, flux_err, ax, direction='sun', which_fit='best', e_min=None, e_max=None, g1_guess=-2., g2_guess=None, g3_guess=None, alpha_guess=5., beta_guess = 5, break_low_guess=0.065, break_high_guess=0.12, cut_guess = 0.12, I0_guess=None, exponent_guess = 2, use_random = False, iterations = 10, path = None, path2 = None, detailed_legend = False): | ||
| def MAKE_THE_FIT(spec_e, spec_flux, e_err, flux_err, ax, direction='sun', which_fit='best', e_min=None, e_max=None, g1_guess=-2., g2_guess=None, g3_guess=None, alpha_guess=5., beta_guess = 5, break_low_guess=0.065, break_high_guess=0.12, cut_guess = 0.12, I0_guess=None, E_0=0.1, exponent_guess = 2, use_random = False, iterations = 10, path = None, path2 = None, detailed_legend = False): |
There was a problem hiding this comment.
I would assume that if I0_guess=None, then also E_0=None?
There was a problem hiding this comment.
This was accidentally undone along with all other progress, but should be there now!
There was a problem hiding this comment.
I mean my question about E_0=0.1
There was a problem hiding this comment.
That is exactly what I meant. It is set back to E_0 = None in the latest commit, which was accidentally undone in the previous commit.
There was a problem hiding this comment.
My initial comment is older than the commit you're referring to. But I see now that you had changed this after my initial comment (without mentioning), and before the "previous commit"
|
I assume the tests are failing because you have an older matplotlib version locally installed (they changes the font handling with 3.11); so you should update the baseline figures using a newer matplotlib version. |
…ing the test baseline images.
jgieseler
changed the title
2 participants
No description provided.