Add vocabulary to package exports - #39
Merged
Merged
Conversation
PreciousOritsedere
requested review from
langsamu and
matthieubosquet
as code owners
August 17, 2026 11:29
langsamu
requested changes
Aug 17, 2026
langsamu
left a comment
langsamu
left a comment
Contributor
There was a problem hiding this comment.
This looks good.
Could you please add a test that ensures this functionality.
Contributor
Author
langsamu
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds @solid/object/vocabulary to the package exports so apps can import IRI constants like ACP instead of maintaining their own vocabulary copies.