Skip to content

Cap solid-js and router peers to the 1.x line before Solid 2.0 - #80

Merged
ryansolid merged 1 commit into
mainfrom
claude/project-thread-5a5axv
Nov 2, 2026
Merged

ryansolid merged 1 commit into
mainfrom
claude/project-thread-5a5axv

Conversation

@ryansolid

Copy link
Copy Markdown
Member

Requested by Ryan · project thread

The 1.x line of @solidjs/testing-library peers on solid-js >=1.0.0 and @solidjs/router >=0.9.0, which Solid 2.0.0 and router 2.x satisfy. This caps both to the 1.x line. Solid 2 support lives on the next tag (1.0.0-rc.x).

  • solid-js: >=1.0.0 → ^1.0.0
  • @solidjs/router: >=0.9.0 → >=0.9.0 <2 (router 1.x is the Solid 1 line; 2.0.0-next is Solid 2)
  • version 0.8.9 → 0.8.11: npm latest is already 0.8.10 (published from b52ffe3) while main still said 0.8.9. This repo has no changesets or release workflow, so it publishes by hand (pnpm publish, prepublishOnly builds).
  • pnpm install --frozen-lockfile still passes

Generated by Claude Code

solid-js >=1.0.0 -> ^1.0.0 and @solidjs/router >=0.9.0 -> >=0.9.0 <2, so
this line doesn't install against Solid 2.0 or router 2.x. Solid 2
support ships on the next tag. Version goes to 0.8.11 since 0.8.10 is
already on npm (published from b52ffe3) and main still said 0.8.9.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWKChs1jT15HHLCEnHn
@ryansolid ryansolid self-assigned this Nov 2, 2026

Copy link
Copy Markdown
Member Author

CI note: the one failing test, testEffect runs with owner (src/__tests__/basic.tsx:227), isn't caused by this PR. It also fails on main (run 33752578791, 89896b8, Sept 3), and I reproduced it locally on main: 1 failed, 106 passed.

Cause: #67 wrapped fn in catchError inside testEffect, which adds an owner level. The effect's getOwner().owner is now the catchError owner, not the passed owner. The test's expectation predates that change. A fix would change only the test, either by walking one more .owner up or by asserting that owner is an ancestor. I haven't included it here, to keep this PR to the peer caps.


Generated by Claude Code

@ryansolid
ryansolid merged commit bdf68b7 into main Nov 2, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants