Repository navigation
docs: onFlush and the hydration tracking run in the skill and cheatsheet; cached import() note (#4332) - #4335
Merged
Merged
Conversation
…eet; cached import() note (#4332) - solid-2.0 skill: land a write on its own with onFlush; never cache a promise or import() created inside a compute (hydration's tracking run). - CHEATSHEET: onFlush import and example; hydration adopts server answers, a hydrated Errored keeps the server fallback, no promise caches in computes. - 05-async-data: a cached dynamic import() under Vite's __vitePreload is the fake Promise too (#4332). - babel-plugin README: runs on @babel/core 7.20.12+ and 8. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0117BoWLQXHbGurmfMSCBeKX
|
Size (brotli, eager entry chunk)
|
Coverage Report for CI Build 40622646846Coverage remained the same at 78.727%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Merging this PR will not alter performance1 warning
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ryan · project thread
Summary
This is the in-repo half of the 2.0 docs gap sweep; the site half is solidjs/solid-docs#1674. Docs only, so there is no changeset.
skills/solid-2.0/SKILL.mdgets two new gotchas, since agents read this skill first:onFlush, notqueueMicrotask/setTimeout(feat(signals): add onFlush to keep a write out of another update's hold #4292).Promise/fetch, so never cache a promise orimport()created inside a compute (2.0 rc: subFetch swaps the global Promise during hydration; user-cached import() becomes a never-settling MockPromise #4332).CHEATSHEET.md:onFlushto the imports, with the menu example.<Errored>keeps the server fallback (fix(solid): hydrated Errored boundary runs its content in the hydration pass #4279), and promise caches don't belong in computes.05-async-data.md, in "the tracking run": adds the 2.0 rc: subFetch swaps the global Promise during hydration; user-cached import() becomes a never-settling MockPromise #4332 case. A cached dynamicimport()under Vite's__vitePreloadis the fake Promise too, andlazy()already avoids it.@babel/core7.20.12+ and 8 (feat(babel-plugin): support @babel/core 8 alongside 7 #4309).This should let #4332 close as a docs issue once merged, unless you want a runtime change there too.
How did you test this change?
prettier --writeon the touched files. Nothing executable changed.Generated by Claude Code