[alukach]

Follows #667, now merged, and the discussion there about keeping the data proxy's endpoints from drifting.

What

The data proxy is the one consumer this API has to stay compatible with. The CLI is being built against the API now, so it follows the spec rather than pinning it. This PR adds one test, which fails CI when a change reshapes an endpoint the proxy calls. It changes no route and nothing in the published spec.

• data-proxy-contract.test.ts keeps PROXY_CALLS, the list of calls the proxy makes, taken from data.source.coop's src/source_api/cache.rs. It fails if one of them leaves the generated document.
• The snapshot. For each call the test snapshots the operation's parameters, request body, statuses and 200 schema, with $refs resolved and descriptions stripped. Rewording an endpoint's docs doesn't trip it, but renaming trusted, removing a status, or changing limit's bounds does. The snapshot pins the 200 body and the status list, because those are all the proxy reads. It treats 200 as the only success, 404 as a missing bucket and 401/403 as a refusal, and never reads an error body.

Pinned here:

• GET /products/{account_id}
• GET /products/{account_id}/{product_id}
• GET /products/{account_id}/{product_id}/permissions
• POST /accounts/{account_id}/trusts/exchanges
• POST /service-account-keys/exchanges

The proxy's sixth call, GET /data-connections/{data_connection_id}, isn't in the generated document until #657 lands. That PR, or a follow-up to it, adds one line to PROXY_CALLS.

PROXY_CALLS is kept by hand, so it can't notice the proxy starting to call something new. That half belongs on the proxy's side: source-cooperative/data.source.coop#256 checks its stub routes against the published spec.

When the test fails

An added optional field is safe, because the proxy's serde types ignore unknown fields, and jest -u accepts it. A removed or retyped field, a changed status, or a new required parameter needs the data.source.coop change first. The comment above the snapshot test says so.

What it doesn't catch

Behavior the spec doesn't express. Two examples are answering an unknown key with 200 {"active": false} rather than a 404, and saying no to a trust with a 403. Those stay with the route and operation tests that already assert them.

Snapshot size

The snapshot is 1,452 lines, almost all of it the Product schema with its embedded Account union, once for the product and once per item in the account's listing. Any change to Product or Account will show up here as a snapshot diff, which is the point: the proxy deserializes those bodies.

Docs, ADRs and llms.txt

No user-facing behavior changes, so docs.source.coop and llms.txt are unaffected. This is a guard in this repo's tests rather than a decision shared with the proxy, so no data.source.coop ADR changes; ADRs 005, 007, 013 and 014 still describe these endpoints.

Testing

• npm run type-check passes.
• npx jest --ci src/app/api/openapi: 36 tests, 5 snapshots pass; the snapshots are unchanged from the first commit.
• Checked that the test bites: renaming trusted to trust in the trust exchange's answer schema fails it with a diff naming the field.

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
source-coop-ui	Ready	Preview	Oct 16, 2026 2:33am UTC
source-cooperative	Ready	Preview	Oct 16, 2026 2:33am UTC

[claude]

Claude finished @alukach's task in 14s —— View job

---

❌ Changes requested — see findings below.

Blocking

• src/app/api/openapi/data-proxy-contract.test.ts:34: shape drops every key named description, summary, example or examples at any depth. That includes property names inside a schema's properties map. Product very likely has a description property, and its snapshot is the biggest part of this PR. Removing or retyping that field, or changing its type, would therefore not change the snapshot. The test would pass on exactly the kind of change it exists to catch. required would still list the name, but nothing else would pin it. Check the snapshot for description under properties. Strip prose only when the key isn't a property name:

const PROSE = ["description", "summary", "example", "examples"];
const shape = (value: unknown, inProperties = false): unknown =>
  Array.isArray(value)
    ? value.map((v) => shape(v))
    : value && typeof value === "object"
      ? Object.fromEntries(
          Object.entries(value)
            .filter(([key]) => inProperties || !PROSE.includes(key))
            .map(([key, v]) => [key, shape(v, key === "properties" && !inProperties)])
        )
      : value;

After the fix, regenerate the snapshot (jest -u). It should gain the property-named entries, and the diff is worth reading.

Simplify (ponytail)

• data-proxy-contract.test.ts:21-25: the Operation type and the cast in beforeAll could go. Type paths as any (or a one-line cast) instead.
• data-proxy-contract.test.ts:28: with the fix above, the helper grows. If the proxy reads no prose fields, an alternative is to snapshot without stripping and accept the docs-reword churn. Keeping the stripper is the better choice, but note the tradeoff.

Docs

The description names the docs, llms.txt and ADRs 005, 007, 013 and 014, and says why they still hold. Nothing to add.

---

💰 Estimated review cost: $0.10 · 0m13s · 4 turns

[alukach]

Not sure this should be done in this codebase, rather the data proxy should have these tests