Repository navigation
fix(ahp): preserve tool results when observers fail - #282
Merged
Merged
Conversation
danielkov
commented
Oct 18, 2026
danielkov
enabled auto-merge (squash)
October 18, 2026 15:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve completed tool results when an observe-only
tool.afterhook fails during preparation or dispatch. Retain attachment ownership through the SDK's typed boundary and surface sanitized dispatch diagnostics through the existing session hook-message channel.Motivation
Kit discarded owned attachment sources when converting
tool.afterinputs to raw events. It also converted top-level observer preparation failures intoCustomPolicyDenied, withholding otherwise successful tool results.Technical details
Use the typed
tool_afterSDK entry point so binary attachment sources survive projection and participate in SDK preparation. Observer-only dispatch failures retain the native outcome, including output and execution metadata.Any registered
tool.afterinterceptor conservatively retains fail-closed behavior for dispatch failures, including mixed observer/interceptor configurations and payload-filtered interceptors. Native failures and cancellation remain intact.Diagnostics expose the SDK classification rather than arbitrary error strings that may contain output or secrets. This change does not raise attachment limits or alter the SDK's attachment-admission ordering.