Repository navigation
chore(php): set up latest PHP 8.3 in test-generator and keep Composer timeout - #131
Merged
Merged
Conversation
…elog] The test-generator job runs PHP snapshot tests that call `composer update`, but it had no setup-php step and used the runner image's preinstalled PHP. roave/security-advisories (dev-latest) conflicts with PHP 8.3 releases older than 8.3.36, so Composer refused to resolve dependencies on the image's 8.3.6. Add the same pinned setup-php step used by test-php.yml, with `update: true` so the latest 8.3 patch is installed on every run.
…hangelog] setup-php exports COMPOSER_PROCESS_TIMEOUT=0 to later steps, and Composer reads that variable before its config, so `process-timeout 300` set by the "Configure Composer" steps had no effect and stalled commands ran unbounded. Pass COMPOSER_PROCESS_TIMEOUT: 300 to setup-php so it exports that value instead, and drop the overridden `composer config process-timeout` calls.
2ynn
marked this pull request as ready for review
October 22, 2026 01:50
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. Updates CI workflows to run the latest PHP 8.3 patch via setup-php and preserve Composer's 300s process timeout; dev-only configuration with no generator or generated output changes.
View guided diff | Turn on auto-fix | Re-trigger cubic
TristanSpeakEasy
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
test-generatorjob fails in the PHP snapshot tests (e.g.TestSnapPhpModelNamespaceUnusedImport) whencomposer updateruns on the generated SDK:test-generatorhas nosetup-phpstep, so it uses the PHP preinstalled on the runner image (8.3.6). Generated PHP SDKs requireroave/security-advisories: dev-latest, which now conflicts with PHP 8.3 releases older than 8.3.36. #127 madetest-php.ymlinstall the latest 8.3 patch, buttest.ymlwas not covered.Adding
setup-phpbrings a second issue: it exportsCOMPOSER_PROCESS_TIMEOUT=0to later steps, and Composer reads that variable before its config. Thecomposer config --global process-timeout 300calls in both workflows were therefore overridden, leaving Composer processes with no timeout. This was already the case intest-php.yml.What changed
.github/workflows/test.yml: add the same pinnedsetup-phpsteptest-php.ymluses (php-version: "8.3",update: true) totest-generator, before the Composer steps..github/workflows/test.yml,.github/workflows/test-php.yml: passCOMPOSER_PROCESS_TIMEOUT: 300tosetup-phpso it exports that value instead of0, and drop the now-overriddencomposer config --global process-timeout 300calls.No generator or template changes; no generated output changes.
Testing
git diff --checkis clean.updateis read from the step environment, not fromwith:inputs (src/scripts/unix.shin setup-php v2.37.2).COMPOSER_PROCESS_TIMEOUTset on the step replaces the0default in setup-php'scomposer.env(set_composer_envinsrc/scripts/tools/add_tools.sh).test-generatorand PHP jobs on this PR exercise the change.Follow-up, not addressed here: because generated SDKs depend on
roave/security-advisories: dev-latest, a future PHP security release can break CI again until setup-php's prebuilt PHP builds include the new patch.Public-safety check
.claude/skills/public-repo-communication/SKILL.md).git diff --check.Summary by cubic
Fixes the
test-generatorCI job, which failed when Composer could not resolve dependencies on the runner's preinstalled PHP 8.3.6.setup-phpstep (php-version: "8.3",update: true) used bytest-php.ymlso the latest 8.3 patch is installed.COMPOSER_PROCESS_TIMEOUT: 300tosetup-phpin both workflows, because it exportsCOMPOSER_PROCESS_TIMEOUT=0to later steps, overriding the removedcomposer config --global process-timeout 300calls.Written for commit fe5880b. Summary will update on new commits.