Skip to content

Close DB map in DB server thread - #626

Merged
soininen merged 1 commit into
masterfrom
fix_db_server_db_map_close
Sep 10, 2026
Merged

soininen merged 1 commit into
masterfrom
fix_db_server_db_map_close

Conversation

@soininen

@soininen soininen commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

This PR fixes a Traceback that could happen when calling SpineDBServerBase.close_db_map().

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

DatabaseMappings must be closed in the same thread
they were created in.
@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.15%. Comparing base (5b487d9) to head (a7094be).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #626   +/-   ##
=======================================
  Coverage   86.15%   86.15%           
=======================================
  Files          83       83           
  Lines       11477    11477           
  Branches     1636     1636           
=======================================
  Hits         9888     9888           
  Misses       1238     1238           
  Partials      351      351           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@soininen
soininen merged commit 1e9110b into master Sep 10, 2026
17 checks passed
@soininen
soininen deleted the fix_db_server_db_map_close branch September 10, 2026 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant