Repository navigation
Conversation
itowlson
force-pushed
the
component-manifest-packaging
branch
from
October 19, 2026 00:04
2c4e2f4 to
66251e1
Compare
Contributor
Author
|
It looks like the code included with the SIP is quite out-of-date, e.g. the code derives the namespace from the registry (if I'm reading this right) whereas the SIP has had the name in the manifest being namespace-qualified for quite a while. My guess is Michelle was using the code to POC some of the hairier bits like embedding, and not worrying too much about keeping every part of it up to date as the SIP developed. So once the SIP looks okay we'll need to give the code a bit of a Paddington Bear stare. |
itowlson
force-pushed
the
component-manifest-packaging
branch
from
October 26, 2026 22:41
9a400b8 to
86a4d1e
Compare
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
itowlson
force-pushed
the
component-manifest-packaging
branch
from
October 26, 2026 22:43
86a4d1e to
5a648cf
Compare
Contributor
Author
|
After guidance from @fibonacci1729 I've removed Michelle's code (we can refer to her PR if we need it again). |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This picks up Michelle's existing work in #3697 (I show up as co-author on her commits only because of rebasing).
Currently this includes Michelle's work in the code - I am not sure of the status of that but longer term we will presumably want to split it out from the SIP.So far this has light rework and detailing, but I'll work through comments on Michell's original PR (especially Till's lengthy brain dump) in future commits.