Repository navigation
GH-1971 - Only claim event publications for resubmission that are still failed - #1972
Open
Adrastopoulos wants to merge 1 commit into
Open
Adrastopoulos wants to merge 1 commit into
Adrastopoulos wants to merge 1 commit into
Conversation
…on that are still failed. FailedEventPublications.resubmit(…) reads failed publications and claims each one via markResubmitted(…), which only required the publication to be incomplete and not RESUBMITTED. A publication that a concurrent resubmission had claimed and moved to PROCESSING could thus be claimed again, and its listener was invoked a second time. markResubmitted(…) now takes the status the caller expects the publication to have, like markAbandoned(…). processFailedPublications(…) passes FAILED, and the JDBC, JPA, MongoDB and Neo4j repositories then only claim publications with that status or without one. The resubmission of incomplete publications passes null and keeps claiming PUBLISHED and PROCESSING ones. Signed-off-by: Gabriel Hall <gabriel.hall@cox.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1971.
markResubmitted(…)now takes the status the caller expects the publication to have, likemarkAbandoned(…)(#1764).processFailedPublications(…)passesFAILED, and the JDBC, JPA, MongoDB and Neo4j repositories then only claim publications with that status or without one. A publication that a concurrent resubmission has claimed and moved toPROCESSINGis no longer claimed a second time. The resubmission of incomplete publications (IncompleteEventPublications, republication on restart) passesnulland keeps the previous condition.On the
EventPublicationRepositorySPI,markResubmitted(UUID, Instant)becomesmarkResubmitted(UUID, Instant, Status).Tests:
doesNotResubmitFailedPublicationThatHasBeenConcurrentlyResubmitted()claims a failed publication, marks it processing and claims it again. The Implementations ofApplicationEventwrongly rewrapped intoPayloadApplicationEvent#1565 null status tests now claim withFAILED.markProcessing(…), soresubmitsPublicationOnlyIfInExpectedStatus()stores aPROCESSINGpublication directly, andresubmitsFailedPublicationWithoutStatus()covers a document without status.DefaultEventPublicationRegistryUnitTests:processFailedPublications(…)claims withFAILED.The new tests fail without the fix. The core, JDBC, JPA, MongoDB and Neo4j modules pass with
./mvnw verify.