Repository navigation
fix: expose overlay dismissal as an empty accessibility container - #23
Open
RoyalPineapple wants to merge 3 commits into
Open
RoyalPineapple wants to merge 3 commits into
RoyalPineapple wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
RoyalPineapple
marked this pull request as ready for review
October 15, 2026 14:17
RoyalPineapple
commented
Oct 15, 2026
| override var isAccessibilityElement: Bool { | ||
| get { onAccessibilityActivate != nil } | ||
| get { false } | ||
| set { fatalError("Not settable") } |
Contributor
Author
There was a problem hiding this comment.
maybe not fatalerror,
Contributor
Author
There was a problem hiding this comment.
🤖 Changed both setters (isAccessibilityElement and accessibilityContainerType) to no-ops, so external writes are ignored instead of crashing. Added test coverage that writes don't change either value.
Contributor
Author
There was a problem hiding this comment.
🤖 Switched both setters to assertionFailure("Not settable"): catches writes in debug, ignored in release. Dropped the write-ignoring test since it would now trap in debug.
…ping Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
soroushsq
approved these changes
Oct 15, 2026
Comment on lines
+1853
to
+1859
| get { onAccessibilityActivate != nil } | ||
| set { fatalError("Not settable") } | ||
| get { false } | ||
| set {} | ||
| } | ||
|
|
||
| override var accessibilityContainerType: UIAccessibilityContainerType { | ||
| get { onAccessibilityActivate != nil ? .semanticGroup : .none } | ||
| set {} |
There was a problem hiding this comment.
Do we have any concerns here? Have we done this anywhere else?
Contributor
Author
There was a problem hiding this comment.
no this is the sole place we set a dismissal overlay. or at least we don't do it within market.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The overlay's "Dismiss popup" target was a leaf accessibility element, so VoiceOver put it in the swipe order alongside the modal content. This brings the implementation in line with the default dimming view behavior.
OverlayViewnow reportsisAccessibilityElement = falseand, when overlay-tap dismissal is enabled,accessibilityContainerType = .semanticGroup. It stays behind the content with no children. Label, hint, and activation are unchanged. VoiceOver focuses the empty group when the user touches outside the content, and double-tap still dismisses; the escape gesture is unaffected.Verified on device with VoiceOver against Market popovers.
Checklist
🤖 Generated with Claude Code