Repository navigation
Copy the generated dictionary data into desktop builds - #360
Merged
Merged
Conversation
Contributor
|
Merge verdict: SAFE TO MERGE (PR guard passed on b7bf3d6). Use "Squash and merge". PR guard output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope: .github/scripts/build_desk.py
With #359 in, the v0.1.4 desktop builds got further, but the Linux and macOS smoke tests failed (run). Their check for
squirrelgo-dictionary/www/data/meta.jsfound nothing. The workflow generates that folder withtools/fetch_data.sh, but it's gitignored, and the build script only copied tracked files. The Windows build passed only because Windows has no smoke test, so its zip was missing the dictionary data too. Desktop builds have failed on every release since v0.1.0.The build script now also copies a short list of generated folders when they exist, currently just the dictionary's
www/data/, and prints a warning when one is missing.After merge, rerun Desk desktop builds with tag
squirrelgo-v0.1.4.Checks:
python3 .github/scripts/pr_guard.py --base origin/main --head HEAD