Repository navigation
Attach Orthodox Bible packs to their own GitHub release - #361
Merged
Merged
Conversation
Stop putting the downloadable Bible and commentary packs on each SquirrelGo release. A dedicated orthodox-bible-packs release holds them, and the app checks that tag instead of the latest release.
Contributor
|
Merge verdict: SAFE TO MERGE (PR guard passed on 949e394). Use "Squash and merge". PR guard output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope: .github/workflows/squirrelgo-orthodox-release-packs.yml, .github/workflows/squirrelgo-orthodox-packs.yml, .github/workflows/squirrelgo-release.yml, SquirrelGo-Apps/squirrelgo-orthodox-bible/, docs/RELEASES.md, docs/RELEASE_PLAN.md, PRIVACY.md
The Orthodox Bible's downloadable Bibles and commentary were attached to every published SquirrelGo release, which cluttered the app-build releases. They now go to a dedicated release tagged
orthodox-bible-packs.The "SquirrelGo Orthodox Bible release packs" workflow no longer runs when a SquirrelGo release is published. It runs when the pack-build workflow finishes successfully on main, or by hand. It creates that dedicated release if it is missing (at main HEAD, with
--latest=falseand--prereleaseso it never becomes the repo's latest release and APK links keep working), uploads the packs with--clobber, and drops pack assets that are no longer in the list. The tag is not moved after it is created.The app's "Check for new texts" now looks at
releases/tags/orthodox-bible-packs, still falling back to theorthodox-bible-textsbranch for the pack list. The sameapp.jsis the Desk and phone app, so they stay twins. User-facing wording no longer mentions a SquirrelGo release tag.Already-installed app versions that look at the latest release will stop finding new packs once the next main SquirrelGo release ships without them. Copies already installed can still use packs from the current latest release until then. After this merges, run the packs workflow by hand once so the dedicated release exists before that next app release.
Checks:
python3 .github/scripts/pr_guard.py --base origin/main --head HEADandnode --checkon the app JS; the changed workflows load as YAML.