Repository navigation
Show French, German and Italian in the Translation Learner - #363
Merged
Merged
Conversation
Those pairs already have column data, passing English tests, and entries in tested.js (#323), but COLUMNS omitted them so the menu never offered them. Add the three ids to COLUMNS and DECKS (Latin-script, no reading column) and keep the practice face on the Latin font stack. Co-authored-by: Squirrelworks <squirelworks@users.noreply.github.com>
Contributor
|
Merge verdict: SAFE TO MERGE (PR guard passed on c1bfb18). Use "Squash and merge". PR guard output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope: translation-learner/
Part of #194
Why
#323 added French/German/Italian–English tests and listed them in
tested.js, butCOLUMNSinapp.jsnever included those ids, so the learner menu did not offer them.What
french,german, anditaliantoCOLUMNSandDECKS(Latin-script decks without a reading column, same as Latin).index.html.Checks
node translation-learner/check.js(pairs ok, including french/german/italian)python3 .github/scripts/pr_guard.py --base origin/main --head HEAD