Add zellij theme in the new format - #5
Conversation
|
looking good, happy to merge when you feel its ready |
|
@MindTooth @nils-degroot I see you guys added it previously, you guys ok with this as well? |
I can test later and report back. |
|
Spotted one error: 
CTRL-g-r |
MindTooth
left a comment
MindTooth
left a comment
There was a problem hiding this comment.
Care to look at the graphical glitch?
MindTooth
added
enhancement
MindTooth
left a comment
MindTooth
left a comment
There was a problem hiding this comment.
Care to check the error in the screengrab I posted? If we can fix it, we can merge.
MindTooth
left a comment
MindTooth
left a comment
There was a problem hiding this comment.
Since this implements the current Zellij theme format, should it replace the existing srcery.kdl and keep the theme name srcery, rather than introducing a separate srcery_v2?
The existing theme is based on the old format, and keeping it as the default would leave users pointed at the obsolete version. If this supersedes it, we should also update the README accordingly.
The palette should also be refreshed against the current srcery-palette.
| } | ||
| text_unselected { | ||
| base 252 232 195 | ||
| background 28 27 25 |
There was a problem hiding this comment.
This uses the old Srcery background (#1C1B19), which is now gray1. The canonical black is #121110 (18 17 16). Could we update this theme against the current srcery-palette and use black versus the gray ramp according to the intended component background?
| srcery_v2 { | ||
| ribbon_unselected { | ||
| base 252 232 195 | ||
| background 58 58 58 |
There was a problem hiding this comment.
Could we use colors from the canonical Srcery gray ramp here instead of custom neutral values? The palette now provides gray1–gray6, so these UI backgrounds should be expressible using Srcery palette colors.
3 participants
The current zellij theme in this repo is a legacy theme, which doesn't fully work with some of the new features, especially plugins. Most notably, any selected items in the interactive plugins don't show up as selected - there's now way of telling what you're doing.
I created this theme for my use and it's definitely not any end-all-be-all configuration, but it seems to look and work well enough.
sample screenshot:
We can hold off with merging it for a while until it's more battle tested and there's more info added to the directory readme, just leavihg this here for now