fix(ev): allow battery boost during Charge now - #74
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ftw-webapp | 26e3ad1 | Commit Preview URL Branch Preview URL |
Sep 27 2026, 03:28 PM |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ebd44fd503
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {#if lp.manualActive} | ||
| <span class="hint">Available after returning to the plan.</span> | ||
| {:else if surplusFor(lp)} | ||
| {#if surplusFor(lp)} |
There was a problem hiding this comment.
When the charger is paused, pauseCharging() represents that as manualActive with a zero hold (isPaused(lp)), but this condition now exposes Start boost for that state. A boost only supplies the battery behind the active loadpoint hold; it does not replace the zero hold, so clicking it starts and consumes the bounded lease while the car remains paused despite the copy promising it will charge. Preserve a paused-state guard while allowing nonzero Charge now holds.
Useful? React with 👍 / 👎.
1 participant
The EV panel hid home battery boost while Charge now was active, although Core supports both together. Keep the boost action available so either can start first; stopping boost leaves Charge now active. A paused charger must resume before starting a boost, including when the boost form was already open.
Validation: the Charge now and paused-state regressions each fail before their fixes. All 1,036 tests, type checks and the production build pass with
vitest --maxWorkers=4; unrestricted local runs hit unrelated chart/escrow timeouts. Contract and token checks pass. Browser checks against the local simulator show both modes active and Charge now continuing after Stop boost. This is simulator evidence, not a hardware run.PR #72 changes ready-time tests in the same file; those cases remain unchanged.