fix(update): show unpacking as its own native step - #1377
Merged
Merged
Conversation
On the home box, v0.134.0-beta.1 reported "Downloading verified Core release 24.0 MB in 12s (2.0 MB/s)". The transfer ran at about 14 MB/s; the rest was verifying and unpacking the release with a sync per file on the SD card, all under the download status. The downloader now reports when the archive is on disk, and step 2 "Unpacking and checking the release" starts there. ftw's progress line was cut at 80 columns. The bar now leaves the numbers about 60 columns. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MuerPFZFG88kgu8sWVHeq7
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found while testing the whole chain on the home box (
homelab-rpi, v0.133.0-beta.1 → v0.134.0-beta.1 with the newftwfrom #1375).✓ 2/4 Downloading verified Core release 24.0 MB in 12s (2.0 MB/s), but the transfer ran at about 14 MB/s. The rest was verifying and unpacking the release, with an fsync per file on the SD card, all under the download status.nativeupdate.Downloadergets aDownloadedcallback once the archive is on disk. Core ends the download step there and starts step 2, "Unpacking and checking the release".… ETA 53s 1…). The bar now leaves the numbers about 60 columns.Tests
internal/selfupdate: the recorded phases are download (with bytes), then unpack. Unpack starts no earlier than download ends.internal/ftwcli: at 80 columns the live line fits with no cut and ends with the elapsed time.make testandgo vet ./...pass.The whole chain follows after merge: beta,
ftw updateon the box (the first run of the new native path on hardware),ftw rollback,ftw update.🤖 Generated with Claude Code
https://claude.ai/code/session_01MuerPFZFG88kgu8sWVHeq7