fix(drivers): bundle Pixii 2.1.6 and verify fault recovery in Core - #1469
Merged
Merged
Conversation
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
frahlg
changed the title
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
Ship the merged Pixii status fix in Core's native package. Moving only the driver repository leaves native updates and offline starts on Pixii 2.1.4.
Move the recovery snapshot to device-drivers commit
7e572fb499dda7acf6f1212b8b0b78235b9d3ba9, containing srcfl/device-drivers#147 and the watched source documentation from srcfl/device-drivers#148. Across the 40 existing bundled drivers, only Pixii's bytes change. The bundled driver list stays the same.Scope and safety
Owner requested merge, beta publication and installation after #1468. #1449 also touches the snapshot pin to add vehicle drivers; this required Pixii release update keeps its proposed driver additions separate and leaves its branch intact. When that PR lands, retain this fix in its chosen driver commit.
A Core host regression loads the bundled Lua and checks unknown → testing → unsupported → unrecognized → charging. Unknown status at start creates no calibration fault, unknown status cannot clear an existing fault, recognized recovery clears it, and battery/meter telemetry continues. No ramp or setpoint behavior changes. Physical Pixii validation remains outstanding.
Verification
pixiichanged.make driversandmake driver-versions-across-pinpassed.make verifypassed on the new snapshot.go test ./internal/drivers -run '^TestPixii' -count=1passed, including the added Core host regression.