Repository navigation
Prevent scene worker restarts during Windows shutdown - #137
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Windows shuts down, it can terminate the scene worker before the desktop tray app. RenderOffload then treats that exit as a crash and can launch a replacement into the dying session, consistent with the reported
0xc0000142popup.Check
SM_SHUTTINGDOWNbefore supervising the worker and again immediately beforeCreateProcess. Stop the existing worker while shutdown is active; normal retries resume if shutdown is cancelled.Validation: Linux RenderOffload build passed; all five worker registry/render/contract/singleton/build-dependency smoke tests passed after rebuilding stale worker artifacts. Windows compilation is covered by CI. The original popup was not reproduced through a real shutdown, so the shutdown-race diagnosis remains inferred. No shutdown was triggered on winpc.
Screenshots and scene previews skipped: process-lifecycle change with no rendered UI or scene changes.
📦 Build artifacts
Built from
12ad3d3· CI run