fix: provide container plugin path to memcheck tests - #3941
Open
robbycochran wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## collector-container-plugin #3941 +/- ##
===========================================================
Coverage 27.33% 27.33%
===========================================================
Files 94 94
Lines 5399 5399
Branches 2538 2538
===========================================================
Hits 1476 1476
Misses 3197 3197
Partials 726 726
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set
ROX_COLLECTOR_CONTAINER_PLUGIN_PATHfor the separately registeredmemcheck_CTest entries, just as it is set for the normal unit tests.Targets
collector-container-plugin(#3939); this is a sibling of #3940, not dependent on the validator changes. One-line test configuration fix, no production changes.Failure
Both existing Valgrind unit-test jobs fail
SystemInspectorServiceTest.FilterEventbefore loading the plugin:CTest's environment property is attached to the normal test, not automatically inherited by the separately registered
memcheck_SystemInspectorServiceTest.Failing jobs: AMD64, ARM64. Both report 32/33 tests passing; the sole failed entry is
memcheck_SystemInspectorServiceTest. This addresses the missing-environment assertion, not the separate library diagnostics in Valgrind output.Validation
-DUSE_VALGRIND=ON -DCMAKE_BUILD_TYPE=Debugsucceeds.ctest --show-only=json-v1confirms identical plugin-path environment values for normal and memcheck SystemInspectorServiceTest entries.git diff --checkpasses.skip-integration-testsskips the broad VM/Kubernetes matrix for this test-configuration-only fix; existing unit-test jobs remain enabled.