Skip to content

fix: use local container id cache instead of container plugin - #3953

Draft
Stringy wants to merge 1 commit into
collector-container-pluginfrom
giles/collector-local-container-id-cache
Draft

fix: use local container id cache instead of container plugin#3953
Stringy wants to merge 1 commit into
collector-container-pluginfrom
giles/collector-local-container-id-cache

Conversation

@Stringy

@Stringy Stringy commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Description

A detailed explanation of the changes in your PR.

Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.

For more details, ref the Confluence page about this section.

@codecov-commenter

codecov-commenter commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.61345% with 79 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.32%. Comparing base (249fe75) to head (ef8157f).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ollector/lib/system-inspector/ContainerIDCache.cpp 16.21% 23 Missing and 8 partials ⚠️
collector/lib/system-inspector/ContainerIDCache.h 0.00% 11 Missing ⚠️
...or/lib/system-inspector/ContainerIDFilterCheck.cpp 58.33% 4 Missing and 6 partials ⚠️
collector/lib/Utility.cpp 57.89% 2 Missing and 6 partials ⚠️
collector/lib/system-inspector/Service.cpp 41.66% 6 Missing and 1 partial ⚠️
collector/lib/ProcessSignalFormatter.cpp 33.33% 3 Missing and 3 partials ⚠️
collector/lib/NetworkSignalHandler.cpp 0.00% 3 Missing ⚠️
collector/lib/CollectorService.cpp 0.00% 1 Missing ⚠️
collector/lib/Process.cpp 0.00% 1 Missing ⚠️
collector/lib/system-inspector/Service.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##           collector-container-plugin    #3953      +/-   ##
==============================================================
- Coverage                       27.33%   27.32%   -0.02%     
==============================================================
  Files                              94       97       +3     
  Lines                            5399     5472      +73     
  Branches                         2538     2561      +23     
==============================================================
+ Hits                             1476     1495      +19     
- Misses                           3197     3243      +46     
- Partials                          726      734       +8     
Flag Coverage Δ
collector-unit-tests 27.32% <33.61%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@Stringy
Stringy force-pushed the giles/collector-local-container-id-cache branch from 490c81b to a1aa6d3 Compare September 9, 2026 14:57
@Stringy
Stringy force-pushed the giles/collector-local-container-id-cache branch from a1aa6d3 to ef8157f Compare September 9, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants