Skip to content

chore: move dependencies used by a single crate to said crate (#1729) - #1732

Open
Molter73 wants to merge 1 commit into
release-0.4from
mauro/chore/move-deps-0.4
Open

chore: move dependencies used by a single crate to said crate (#1729)#1732
Molter73 wants to merge 1 commit into
release-0.4from
mauro/chore/move-deps-0.4

Conversation

@Molter73

@Molter73 Molter73 commented Sep 10, 2026

Copy link
Copy Markdown
Member

Description

After an automated update of bindgen broke our build due to a dependency conflict, I did some digging and turns out that was solved by simply moving the bindgen dependency to fact-ebpf which is the only crate that needs it. In order to reduce the chances of this kind of breakage from happening, we are moving all dependencies that are needed by a single crate to said crate.

Checklist

  • Patch has a change log entry OR does not need one.
  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

CI is enough.

After an automated update of bindgen broke our build due to a dependency
conflict, I did some digging and turns out that was solved by simply
moving the bindgen dependency to fact-ebpf which is the only crate that
needs it. In order to reduce the chances of this kind of breakage from
happening, we are moving all dependencies that are needed by a single
crate to said crate.
@Molter73
Molter73 requested review from a team and rhacs-bot as code owners September 10, 2026 13:39
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)
  • main
  • ^release-*$

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Enterprise

Run ID: 40e4e055-164d-407c-9f4f-4684318e2b58

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.40%. Comparing base (ca8d926) to head (9a671f4).

Additional details and impacted files
@@             Coverage Diff              @@
##           release-0.4    #1732   +/-   ##
============================================
  Coverage        33.40%   33.40%           
============================================
  Files               22       22           
  Lines             3628     3628           
  Branches          3628     3628           
============================================
  Hits              1212     1212           
  Misses            2407     2407           
  Partials             9        9           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants