Skip to content

fix: align reusable review skill staging - #172

Open
robbycochran wants to merge 1 commit into
mainfrom
fix/reusable-review-skill-path
Open

fix: align reusable review skill staging#172
robbycochran wants to merge 1 commit into
mainfrom
fix/reusable-review-skill-path

Conversation

@robbycochran

@robbycochran robbycochran commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Stage the default and caller-supplied review skill at one stable path outside the example directory.
  • Make the reviewer workflow payload select that path explicitly through REVIEW_SKILL.
  • Add regression coverage that uses a custom marker and verifies the example uploads those exact bytes.

Validation

  • go build ./...
  • go vet ./...
  • CGO_ENABLED=0 go test ./...
  • actionlint
  • shell syntax checks
  • make test-suite

golangci-lint is installed locally but cannot parse this repository's config with the installed version; it reports a config decoding error before analysis.

Summary by CodeRabbit

  • New Features

    • Review workflows now support custom review skills, allowing caller-provided instructions to override the default skill after validation.
    • Review configuration dynamically uses the selected skill, with a standard default applied when no custom skill is provided.
    • The workflow verifies that the selected skill is copied and available before review execution.
  • Tests

    • Added integration coverage confirming custom skills are loaded and uploaded with the expected content and destination.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 3befbc51-0069-4990-885a-67794387c922

📥 Commits

Reviewing files that changed from the base of the PR and between 211781c and 6c15d26.

📒 Files selected for processing (4)
  • .github/workflows/pr-review-reusable.yml
  • cmd/workflow_apply_test.go
  • examples/github-pr-reviewer/opencode-harness.yaml
  • scripts/pr-review.sh

Included review availability: Your plan provides up to 12 included reviews per hour; 7 remain after this review.


Walkthrough

The review flow now selects a configurable skill path, installs it into the runtime skill directory, passes it through REVIEW_SKILL, and uploads it to the review sandbox. An integration test verifies the uploaded path and content.

Changes

Review skill flow

Layer / File(s) Summary
Skill selection and installation
.github/workflows/pr-review-reusable.yml, scripts/pr-review.sh
run_review selects REVIEW_SKILL. The reusable workflow installs the default or caller-provided skill at harness/skills/pr-review/SKILL.md and verifies the copied file.
Skill payload wiring and validation
.github/workflows/pr-review-reusable.yml, examples/github-pr-reviewer/opencode-harness.yaml, cmd/workflow_apply_test.go
The Harness payload uses REVIEW_SKILL as its source. The workflow passes the selected path to the review process. The integration test verifies the uploaded destination and content.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 6c15d

The review-skill staging, environment wiring, and uploaded sandbox payload are consistent, with regression coverage for caller-supplied skill content.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. (2 skipped: 2 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: aligning reusable review skill staging.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. (2 skipped: 2 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/reusable-review-skill-path

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant