Skip to content

fix(be): Add operating system column to Node CVE reports - #22761

Open
charmik-redhat wants to merge 1 commit into
masterfrom
charmik/add-node-os-to-reports
Open

fix(be): Add operating system column to Node CVE reports#22761
charmik-redhat wants to merge 1 commit into
masterfrom
charmik/add-node-os-to-reports

Conversation

@charmik-redhat

Copy link
Copy Markdown
Contributor

Description

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

  • Unit tests and manual tests

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@openshift-ci

openshift-ci Bot commented Sep 9, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@charmik-redhat
charmik-redhat marked this pull request as ready for review September 9, 2026 22:41
@charmik-redhat
charmik-redhat requested a review from a team as a code owner September 9, 2026 22:41
@charmik-redhat charmik-redhat changed the title feat(be): Add operating system column to Node CVE reports fix(be): Add operating system column to Node CVE reports Sep 9, 2026
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 6e964d9c-e77d-44c2-b811-c520166f3858

📥 Commits

Reviewing files that changed from the base of the PR and between e79bfc8 and ce683c7.

📒 Files selected for processing (4)
  • central/reports/scheduler/v2/reportgenerator/node/csv_gen.go
  • central/reports/scheduler/v2/reportgenerator/node/csv_gen_test.go
  • central/reports/scheduler/v2/reportgenerator/node/report_gen_impl.go
  • central/reports/scheduler/v2/reportgenerator/node/types.go

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Summary

Summary by CodeRabbit

  • New Features
    • Node vulnerability CSV reports now include an Operating System column.
    • Operating system details are populated for each reported node when available.
  • Tests
    • Updated report generation coverage to verify the new column and handling of missing operating system values.

Walkthrough

The node vulnerability report query now retrieves operating-system data. The response type exposes the optional value, and CSV generation includes an Operating System column. Tests cover populated and nil operating-system values.

Changes

Node vulnerability report operating system

Layer / File(s) Summary
Operating system response contract
central/reports/scheduler/v2/reportgenerator/node/report_gen_impl.go, central/reports/scheduler/v2/reportgenerator/node/types.go
The report query selects search.OperatingSystem. NodeCVEQueryResponse stores the nullable value and provides GetOperatingSystem().
CSV output and validation
central/reports/scheduler/v2/reportgenerator/node/csv_gen.go, central/reports/scheduler/v2/reportgenerator/node/csv_gen_test.go
CSV output adds the Operating System header and value. Tests verify populated values and empty output for nil values.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to ce683

Node CVE CSV reports now include an Operating System column, with empty values when the data is unavailable. The change is covered for populated and unset values and has no identified merge-blocking risk.

Suggested reviewers: ajheflin

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely identifies the main change: adding an operating system column to Node CVE reports.
Description check ✅ Passed The description covers documentation status, production readiness, modified tests, and validation. The Description section is empty, and CI inspection is unchecked, but the overall description is suff…
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch charmik/add-node-os-to-reports

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.76%. Comparing base (e79bfc8) to head (ce683c7).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22761      +/-   ##
==========================================
- Coverage   51.80%   51.76%   -0.04%     
==========================================
  Files        2896     2896              
  Lines      182642   182647       +5     
==========================================
- Hits        94617    94549      -68     
- Misses      79735    79786      +51     
- Partials     8290     8312      +22     
Flag Coverage Δ
go-unit-tests 51.76% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Build Images Ready

Images are ready for commit ce683c7. To use with deploy scripts:

export MAIN_IMAGE_TAG=5.0.x-270-gce683c70e2

@openshift-ci

openshift-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown

@charmik-redhat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-22-nongroovy-e2e-tests ce683c7 link false /test ocp-4-22-nongroovy-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant