Repository navigation
fix(aws-sfn): reject StartSyncExecution on STANDARD state machines - #1689
Merged
Merged
Conversation
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StartSyncExecutionnow returnsStateMachineTypeNotSupportedfor a STANDARD state machine, matching real Step Functions, which offers synchronous executions for EXPRESS workflows only. The type check runs after the existence check, so a missing state machine is stillStateMachineDoesNotExist.StopExecutionon an execution that has already closed keeps its current behavior (200 with the originalstopDate, no state change). AWS documents no error for this case, so the behavior is pinned with a test and a code comment and listed under the SFN non-goals.Tests that called
StartSyncExecutionon STANDARD machines now use EXPRESS machines, including the Task and Parallel recursion-guard tests. New provider and SDK wire tests cover both machine types.Part of #1473