Repository navigation
fix(aws-cloudwatchlogs): StartLiveTail event stream - #1715
Open
NitinKumar004 wants to merge 2 commits into
Open
NitinKumar004 wants to merge 2 commits into
NitinKumar004 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds CloudWatch Logs StartLiveTail.
sessionMetadata.sampledis set. A slow client gets up to 10 queued updates or 5000 events, and after that the oldest are dropped.*,logStreamNamesandlogStreamNamePrefixesmutually exclusive and only with one group, a 1024-character pattern parsed with the filterpattern package, and a limit of 15 concurrent sessions (LimitExceededException). An unknown group returns ResourceNotFoundException.liveTailSessionTimeout), measured on the options clock. Data protection masking applies, since events are masked at ingest.server/wire/awseventstreampackage, and Kinesis now uses it too.stream-logs.host from current SDKs works, and so doesstreaming-logs.from older SDKs and the AWS CLI.servealso ends open streams when it shuts down, through a stream-shutdown base context (wire.StreamContext), so they no longer hold the graceful shutdown until its 10s timeout.statusWritergetsUnwrapso frames still flush with--log-requests.Clients send StartLiveTail to a prefixed host:
stream-from aws-sdk-go-v2 andstreaming-from botocore. Againstlocalhost, those names do not resolve. The usage note is in docs/coverage/nongoals/logging.md. It covers a wildcard-DNS host such ashttp://logs.localtest.me:4566or an /etc/hosts entry for the CLI,inject_host_prefix=Falsefor boto3, andsmithyhttp.DisableEndpointHostPrefixin an API option for the Go SDK. Tests cover both prefixes and the Go SDK option.Part of #1476