Conversation
The cue output selector labelled every output `node<N>:<name>` where N was only the node's POSITION in the mappings array, +1. It read neither alias nor role_id nor hostname, so on any cluster the controller — being the first entry — displayed as "node1", and the whole numbering sat one place off the machine names the operator uses (node1=controller, node2=node01, node3=node02). On alquiler1 that made the Midas MR18 outputs, which are physically on the controller, read as another box. Settings already resolved this correctly (3c37609). This applies the same fallback chain to the selector via a shared getNodeLabel(), so both screens name a node the same way. cuems-editor merges role_id/alias/ hostname from network_map.xml into the mappings it serves (CuemsWsServer.merge_node_data), so the fields are available here; the positional number stays as the last fallback, which keeps partial node-identity migrations safe. Cosmetic only: the binding that matters is the uuid inside output_name, which was always right.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cue output selector labelled every output
node<N>:<name>, where N wasonly the node's position in the mappings array, +1. It read neither
aliasnorrole_idnorhostname.Because
cuems-editorserves the controller's owndefault_mappings.xmlasinitial_mappingsand the controller is the first entry, the controller'soutputs displayed as
node1:— and on a cluster whose machines are namedcontroller / node01 / node02 the whole numbering sits one place off:
Found on the alquiler1 rental kit, where it made the Midas MR18 outputs —
physically on the controller — read as another box.
Fix
Settings already resolved this correctly in 3c37609. This applies the same
fallback chain to the selector through a shared
getNodeLabel(), so bothscreens name a node the same way:
formatOutputNameForDisplaygets the same treatment so the public siblingdoes not drift back.
The positional number stays as the last fallback, which keeps partial
node-identity migrations safe (as cuems-frontend's CLAUDE.md promises).
Why the fields are available here
project_mappings.xsd'sNodeTypecarries onlyuuid,mac,audio,video,dmx— the on-disk mappings file can never hold identity fields.cuems-editormergesrole_id/alias/hostnamein at runtime fromnetwork_map.xml(CuemsWsServer.merge_node_data) before serving themappings, which is exactly what the settings label already relies on.
Scope
Cosmetic. The binding that matters is the uuid inside
output_name, whichwas always correct — audio declared on the controller did reach the MR18.
Built and deployed to the alquiler1 controller for verification: the label
now reads
Controller:MR18 Out 1.