Repository navigation
fix(agent): only say credential routing is unsupported when the service sent no mode - #58
Merged
Merged
Conversation
…ce sent no mode The Routing line blamed the service for lacking credential routing whenever route_hosts was missing. A service that supports it also answers full for a binding that covers every host, with no route_hosts. Key the message off routing_mode instead, and drop the per-plan routing modes from the README since both modes are available on paid plans.
A * in a binding's hosts forces full routing; egress_hosts = ["*"] does not affect it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Routing:line printed "this Remote Agent Proxy does not support credential routing yet" wheneverroute_hostswas missing. A service that supports credential routing also answersfull(with noroute_hosts) for a binding that covers every host or names no hosts, so users got a wrong message. The CLI now decides fromrouting_modeinstead: only a response with norouting_mode(an older service) gets the "does not support" line;fullchosen by the service printsRouting: full (all traffic uses the Remote Agent Proxy).fullwhen a binding covers every host.Test plan
cargo test: 518 unit + 19 + 32 integration tests passfull(mode present) vs older service (no mode)