Repository navigation
fix(agent): show progress for remote sessions and say bindings in local agent runs - #62
Merged
Merged
Conversation
agent run --remote created its Agent Proxy session with no spinner, so a slow or failing request left the terminal silent after the startup warnings. Show 'Starting remote agent session...' during the request and 'Remote agent session started (N bindings)' once it opens.
A local agent run loads only its profile's bindings, so its spinner and completion line now read 'Loading bindings...' and 'Bindings loaded (N bindings)'. Plain run keeps 'Loading environment...'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent run --remoteshowed nothing while the Agent Proxy session was created. The request runs after the startup warnings, so a slow or failing one left the terminal silent until the error appeared. It now showsStarting remote agent session...during the request and✓ Remote agent session started (N bindings)once the session opens. The spinner is cleared before any error prints, so text and--jsonerrors look the same as before.Loading bindings...and the completion line✓ Bindings loaded (N bindings). PlainrunkeepsLoading environment.../Environment loaded (N secrets), and egress-only profiles are unchanged.src/handlers/run/entry.rsback above the functions they describe.Test plan
cargo fmt --checkpassescargo testpassed in full before the remote success line was added. After it, the new test passes; the rest of the suite was only run inside a sandbox that blocks local port binding, where the only failures are the proxy, subprocess, telemetry and session tests that need itagent run --remoteshows the spinner and then the started line