Skip to content

fix(agent): show progress for remote sessions and say bindings in local agent runs - #62

Merged
radim10 merged 2 commits into
masterfrom
fix/agent-run-loading-spinners
Oct 8, 2026
Merged

radim10 merged 2 commits into
masterfrom
fix/agent-run-loading-spinners

Conversation

@radim10

@radim10 radim10 commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Summary

  • agent run --remote showed nothing while the Agent Proxy session was created. The request runs after the startup warnings, so a slow or failing one left the terminal silent until the error appeared. It now shows Starting remote agent session... during the request and ✓ Remote agent session started (N bindings) once the session opens. The spinner is cleared before any error prints, so text and --json errors look the same as before.
  • A local agent run now says "bindings", not "environment". It loads only its profile's bindings, so the spinner reads Loading bindings... and the completion line ✓ Bindings loaded (N bindings). Plain run keeps Loading environment... / Environment loaded (N secrets), and egress-only profiles are unchanged.
  • The remote wording says "starting", not "loading", on purpose. Remote binding values never reach the machine; the control plane holds them, so "loading" would be misleading there.
  • Moved two doc comments in src/handlers/run/entry.rs back above the functions they describe.

Test plan

  • Unit tests for the remote started message and for the local loading/loaded messages (singular and plural)
  • cargo fmt --check passes
  • cargo test passed in full before the remote success line was added. After it, the new test passes; the rest of the suite was only run inside a sandbox that blocks local port binding, where the only failures are the proxy, subprocess, telemetry and session tests that need it
  • Checked by hand: agent run --remote shows the spinner and then the started line

agent run --remote created its Agent Proxy session with no spinner, so a
slow or failing request left the terminal silent after the startup
warnings. Show 'Starting remote agent session...' during the request and
'Remote agent session started (N bindings)' once it opens.
A local agent run loads only its profile's bindings, so its spinner and
completion line now read 'Loading bindings...' and 'Bindings loaded (N
bindings)'. Plain run keeps 'Loading environment...'.
@radim10 radim10 self-assigned this Oct 8, 2026
@radim10
radim10 merged commit 32e7495 into master Oct 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant