Repository navigation
fix(agent): don't require an API key for agent docker commands - #64
Merged
Merged
Conversation
`agent docker build`, `status`, `cleanup`, `doctor` and `shell` only touch local Docker resources (and `build --profile` reads a local profile), but they fell through to the default and asked for a Stashbase API key. On a machine with no key, such as a fresh Linux box running an egress-only profile, the sandbox image couldn't be built even though `agent run` itself works without one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent docker buildasked for a Stashbase API key even though it only builds a local image. The same was true ofagent docker status,cleanup,doctorandshell:AgentSubcommand::Dockerwas missing fromrequires_api_key, so it fell through to the default. All five only touch local Docker resources;build --profilereads a local profile.agent runworked without a key, but the sandbox image it needs couldn't be built.Test plan
agent dockersubcommands (andbuild --profile) don't require an API keycargo fmt --checkand fullcargo testpassstashbase agent docker buildruns instead of failing with "API key is required"