Repository navigation
fix(agent): run sandbox commands directly instead of via node's entrypoint - #66
Merged
Merged
Conversation
…point The default sandbox image inherited the node base image's entrypoint, which runs any command it can't find as a Node script. A misspelled agent (`agent run -- claude.`) failed with "Error: Cannot find module '/workspace/claude.'". The image now clears the entrypoint, so the command is exec'd directly and a typo fails with "exec claude. failed: No such file or directory" (exit 127). Every command the image runs is a real executable: the agent, the network holder's `sleep`, and `agent docker shell`, which already sets its own entrypoint. Existing installs keep the old image until it is rebuilt with `stashbase agent docker build --force`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nodebase image's entrypoint, which runs any command it can't find as a Node script, soagent run -- claude.failed withError: Cannot find module '/workspace/claude.'.ENTRYPOINT []). The command is exec'd directly and a typo fails withexec claude. failed: No such file or directory(exit 127). Every command the image runs is a real executable: the agent, the network holder'ssleep, andagent docker shell, which already passes its own--entrypoint bash.stashbase agent docker build --force.Test plan
cargo fmt --checkand fullcargo testpass