Skip to content

test(proxy): accept a reset as the closed connection after revocation - #67

Merged
radim10 merged 1 commit into
masterfrom
fix/flaky-revoked-proxy-test
Oct 9, 2026
Merged

radim10 merged 1 commit into
masterfrom
fix/flaky-revoked-proxy-test

Conversation

@radim10

@radim10 radim10 commented Oct 9, 2026

Copy link
Copy Markdown
Member

Summary

  • revoked_proxy_rejects_requests_without_closing_the_listener failed on Windows at random (seen on fix(run): say how to build a missing sandbox image when nobody can be asked #65): called Result::unwrap() on an Err value: ConnectionReset (os error 10054). After a session is revoked the proxy drops existing connections, and the test expected a clean EOF. On Windows the same drop sometimes arrives as a reset, depending on timing.
  • The test now accepts EOF, ConnectionReset or ConnectionAborted. It still fails if the connection stays open (2 s timeout) or receives data, so it still catches a real regression. No product code changes.
  • No other proxy test asserts a clean close, so this was the only one affected.

Test plan

`revoked_proxy_rejects_requests_without_closing_the_listener` expected a
clean EOF when the proxy drops an existing connection after revocation.
On Windows the drop sometimes arrives as WSAECONNRESET (10054) instead,
depending on timing, which failed CI at random (seen on PR #65). The
test now accepts EOF, ConnectionReset or ConnectionAborted, and still
fails if the connection stays open or receives data.
@radim10 radim10 self-assigned this Oct 9, 2026
@radim10
radim10 merged commit 1168bf4 into master Oct 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant