Repository navigation
test(proxy): accept a reset as the closed connection after revocation - #67
Merged
Merged
Conversation
`revoked_proxy_rejects_requests_without_closing_the_listener` expected a clean EOF when the proxy drops an existing connection after revocation. On Windows the drop sometimes arrives as WSAECONNRESET (10054) instead, depending on timing, which failed CI at random (seen on PR #65). The test now accepts EOF, ConnectionReset or ConnectionAborted, and still fails if the connection stays open or receives data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
revoked_proxy_rejects_requests_without_closing_the_listenerfailed on Windows at random (seen on fix(run): say how to build a missing sandbox image when nobody can be asked #65):called Result::unwrap() on an Err value: ConnectionReset (os error 10054). After a session is revoked the proxy drops existing connections, and the test expected a clean EOF. On Windows the same drop sometimes arrives as a reset, depending on timing.ConnectionResetorConnectionAborted. It still fails if the connection stays open (2 s timeout) or receives data, so it still catches a real regression. No product code changes.Test plan
cargo fmt --checkand fullcargo testpass