Repository navigation
Make disassembly metrics available - #305
Merged
waskyo merged 3 commits intoNov 2, 2026
Merged
Conversation
sipma
reviewed
Oct 30, 2026
sipma
approved these changes
Oct 30, 2026
sipma
left a comment
sipma
left a comment
Contributor
There was a problem hiding this comment.
Thank you! Saving the disassembly metrics is useful to have.
If normal analysis is done, the disassembly metrics are part of the r/<binary>_metrics.xml file. However, if only disassembly is done (chkx analyze -d), that file does not exist, and instead the metrics are saved to s/<binary>_disassembly.xml. This change creates a dataclass to represent the disassembly metrics, AppDisassemblyMetrics, which gets the information from a passed xnode. AppResultMetrics now uses that class to provide the metrics it exposes from the disassembly. AppAccess also gains a method, disassembly_metrics, which tries the two possible locations where they can be found.
it uses the DisassemblyMetrics class to either print the information or save it to json. The DisassemblyMetrics dataclass gained a to_json_result method to support this. Along the way I realized that the AppResultMetrics to_json_result method was asking the disasembly stats to be converted to int/float when they are already of that type
waskyo
force-pushed
the
disassembly_metrics
branch
from
November 2, 2026 15:05
4d783d6 to
0a6eeb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ddata statscommand which prints the statistics or saves them to a json file.