Repository navigation
Fix admin error view dispatch after template split - #95
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI run 38078372361 failed at
AdminErrorPagesTest.php:63: authenticated 404 unexpectedly falls back to standalone HTML instead of renderingdata-lazy-admin-shell.Replace the nested
lazy::errors.pagedispatcher with direct rendering of each independently customizablelazy::errors.{status}view, including the fallback path. Add regression coverage for direct 404 rendering.Note: This targets the new indirection as a possible cause; GitHub CI is required to verify the runtime failure is resolved. One commit, no changes to public routes.