fix: migrate biome.json to Biome 2 and gate formatting in CI - #47
Merged
stephendolan merged 1 commit intoSep 29, 2026
Merged
Conversation
The installed Biome 2 rejected the Biome 1 `files.include`/`ignore` keys, so `format:check` aborted before checking anything. Translate them to `files.includes` with `!` negations (via `biome migrate`), apply the formatter's pending line-wrapping to three files, and run format:check in CI so the config and the source cannot drift unnoticed again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bun run format:checkfails on main:biome.jsonstill uses Biome 1'sfiles.include/ignore, which the installed Biome 2.3.11 rejects before formatting anything. CI never ran this check, so nobody noticed.biome migratetofiles.includes: ["**/src/**/*.ts", "!**/dist", "!**/node_modules"]. The**/prefix matches how Biome 1 globs behaved (they weren't anchored to the config directory), and the!entries take the place ofignore.src/mcp/server.tsand two test files. The changes only re-wrap lines to fitlineWidth: 100. With whitespace stripped, the files are identical to main, except for the optional leading|Biome adds to a multi-line union type inerrors.test.ts. No behavior changes.bun run format:checkafter lint.biome migrateafter a major bump.🤖 Generated with Claude Code