Repository navigation
fix(catalogues): un catalogue qui ne publie aucun lab sort du manifeste, et le générateur le refuse - #370
Closed
stephrobert wants to merge 1 commit into
Closed
fix(catalogues): un catalogue qui ne publie aucun lab sort du manifeste, et le générateur le refuse#370stephrobert wants to merge 1 commit into
stephrobert wants to merge 1 commit into
Conversation
…te, et le générateur le refuse La 0.9.2 a ajouté certificats au manifeste alors que son dépôt était vide : catalog list le proposait, et l'apprenant qui l'installait n'obtenait rien. Le générateur l'écartait de la table sans le refuser au manifeste. Il le refuse désormais ; certificats reviendra quand il publiera son premier lab, nommé par la détection des dépôts oubliés. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Closing without merging. I am folding this change into #369, which ships in 0.9.3. #369 asks for What carries over into the #369 work:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.9.2 added
certificatsto the packaged manifest while its GitHub repository was still empty (no commit pushed; it is a set of skeletons on purpose). Sodsoxlab catalog listoffers it, and a learner who installs it gets nothing.scripts/gen-catalogues.pyleft it out of the README table but did not refuse it in the manifest. That was a regression from the previous script, which stated explicitly that a catalogue without labs has nothing to offer incatalog list.certificatsleaves the manifest.#369 (draft state for a lab and a catalogue, planned for 0.9.3) will give a better answer:
draft: truein the manifest. When it lands, this refusal will exempt draft entries.Type of change
Checklist
Always
ruff check scripts tests: passedmypy src/dsoxlab: N/A, nosrc/Python touchedtests/test_gen_catalogues.py: 8 passed. The new testtest_un_catalogue_sans_lab_publie_est_refusefails on the previous code, wheremain()returned 0.gen-catalogues.py --checkagainst GitHub gives exit 0 and 699 labs measured on 18 repositoriesWhen behavior changes
CHANGELOG.mdandCHANGELOG.fr.md:[Unreleased], to ship in 0.9.3 with [P2] Sortir les décisions durables du code vers des ADR #203 and feat(contrat): un état brouillon pour un lab et pour un catalogue #369Commands / workflows / contract
N/A: no command, workflow or contract change.
🤖 Generated with Claude Code